Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5377#discussion_r29121814
  
    --- Diff: 
network/common/src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java 
---
    @@ -86,4 +117,237 @@ public void testNonMatching() {
           assertFalse(server.isComplete());
         }
       }
    +
    +  @Test
    +  public void testSaslAuthentication() throws Exception {
    +    testBasicSasl(false);
    +  }
    +
    +  @Test
    +  public void testSaslEncryption() throws Exception {
    --- End diff --
    
    I think these methods should be right next to testBasicSasl's definition


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to