Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5377#discussion_r29121766
--- Diff:
network/common/src/main/java/org/apache/spark/network/TransportContext.java ---
@@ -99,9 +108,9 @@ public TransportServer createServer() {
* be used to communicate on this channel. The TransportClient is
directly associated with a
* ChannelHandler to ensure all users of the same channel get the same
TransportClient object.
*/
- public TransportChannelHandler initializePipeline(SocketChannel channel)
{
+ public TransportChannelHandler initializePipeline(SocketChannel channel,
RpcHandler rpcHandler) {
--- End diff --
The rpcHandler vs appRpcHandler thing is definitely confusing to someone
reading this for the first time, please add a comment here or in
TransportContext about the difference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
