mridulm commented on a change in pull request #32114:
URL: https://github.com/apache/spark/pull/32114#discussion_r611288569
##########
File path: core/src/main/scala/org/apache/spark/SparkEnv.scala
##########
@@ -368,10 +374,12 @@ object SparkEnv extends Logging {
} else {
None
}, blockManagerInfo,
- mapOutputTracker.asInstanceOf[MapOutputTrackerMaster])),
+ mapOutputTracker.asInstanceOf[MapOutputTrackerMaster],
+ recentlyRemovedExecutors)),
registerOrLookupEndpoint(
BlockManagerMaster.DRIVER_HEARTBEAT_ENDPOINT_NAME,
- new BlockManagerMasterHeartbeatEndpoint(rpcEnv, isLocal,
blockManagerInfo)),
+ new BlockManagerMasterHeartbeatEndpoint(rpcEnv, isLocal,
blockManagerInfo,
+ recentlyRemovedExecutors)),
conf,
Review comment:
Move the cache into `BlockManagerMasterEndpoint` and hide the impl
detail ?
We can have a cleaner interface here ...
`BlockManagerMasterHeartbeatEndpoint` simply needs a way to validate if an
executor was recently removed - does not need to know if it was a
Cache/Set/etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
