sumeetgajjar commented on a change in pull request #32114:
URL: https://github.com/apache/spark/pull/32114#discussion_r611348500
##########
File path: core/src/main/scala/org/apache/spark/SparkEnv.scala
##########
@@ -368,10 +374,12 @@ object SparkEnv extends Logging {
} else {
None
}, blockManagerInfo,
- mapOutputTracker.asInstanceOf[MapOutputTrackerMaster])),
+ mapOutputTracker.asInstanceOf[MapOutputTrackerMaster],
+ recentlyRemovedExecutors)),
registerOrLookupEndpoint(
BlockManagerMaster.DRIVER_HEARTBEAT_ENDPOINT_NAME,
- new BlockManagerMasterHeartbeatEndpoint(rpcEnv, isLocal,
blockManagerInfo)),
+ new BlockManagerMasterHeartbeatEndpoint(rpcEnv, isLocal,
blockManagerInfo,
+ recentlyRemovedExecutors)),
conf,
Review comment:
Sure.
The same comment applies to already present `blockManagerInfo` map as well.
I could refactor that as well. I was thinking of creating a
`BlockMangerEndpointSharedState` class which contains `blockManagerInfo` and
`recentlyRemovedExecutors`. The class would expose corresponding methods for
lookup and updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
