attilapiros commented on a change in pull request #32114:
URL: https://github.com/apache/spark/pull/32114#discussion_r612363119
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterHeartbeatEndpoint.scala
##########
@@ -44,11 +47,17 @@ private[spark] class BlockManagerMasterHeartbeatEndpoint(
}
/**
- * Return true if the driver knows about the given block manager. Otherwise,
return false,
- * indicating that the block manager should re-register.
+ * Return true if the driver knows about the given block manager or if the
block manager belongs
+ * to a recently removed executor. Otherwise, return false, indicating that
the block manager
+ * should re-register.
*/
private def heartbeatReceived(blockManagerId: BlockManagerId): Boolean = {
- if (!blockManagerInfo.contains(blockManagerId)) {
+ if
(Option(recentlyRemovedExecutors.getIfPresent(blockManagerId.executorId)).isDefined)
{
Review comment:
Nit: same here (Option is not needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
