sumeetgajjar commented on pull request #32114: URL: https://github.com/apache/spark/pull/32114#issuecomment-819053945
> In essence, if I understood correctly, we are adding a `lostExecutorCandidates:Map[String, ExpirationState]` ? > > * If we detect a request to expire an executor comes in - then expire based on (some) policy : timeout since initial expiry/number of expirations/other reasons : else add/update expiration state of candidate. > > * If heartbeat comes in, then remove from candidate set. > > * If explicit remove, then remove from both `executorLastSeen` and `lostExecutorCandidates:Set`. > > > Did I miss anything ? I am fine with this approach. > (I explicitly pulled out magic values out for explanation clarity) Thanks for the comment @mridulm . I believe this [comment](https://github.com/apache/spark/pull/32114#issuecomment-819046189) applies here as well. I believe @attilapiros [suggestion](https://github.com/apache/spark/pull/32114#discussion_r612373538) would take care of both cases where re-registration is trigger without introducing another Cache of `recentlyRemovedExecutors`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
