luhenry commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r618164534
##########
File path: mllib/pom.xml
##########
@@ -142,20 +142,20 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>lapack</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>arpack</artifactId>
+ </dependency>
+
</dependencies>
- <profiles>
Review comment:
I have removed the dependency on `com.github.fommil.netlib:all` in
`dev.ludovic.netlib`, and replaced it with `com.github.fommil.netlib:core` per
your previous message. It's then still up to the Spark user to specify
`-Pnetlib-lgpl` to get the native wrapper in `com.github.fommil.netlib` or not.
In the longer term, I'll add JNI-based native wrappers to
`dev.ludovic.netlib` so that we wouldn't have to rely on
`com.github.fommil.netlib:all` at all. These native wrappers would only depend
on a native BLAS implementation (OpenBLAS or Intel MKL for example) to be
already installed on the machine, but wouldn't ship any GPL/LGPL code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
