luhenry commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r618439810
##########
File path: mllib-local/pom.xml
##########
@@ -75,48 +75,12 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
</dependencies>
- <profiles>
- <profile>
- <id>netlib-lgpl</id>
Review comment:
Is it enough to have this profile in `pom.xml` ([like
so](https://github.com/apache/spark/pull/32253/files/#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R3489-R3499))
or does it need to be in this `mllib-local/pom.xml`?
The results from `dev/test-dependencies.sh --replace-manifest` __without__
`-Pnetlib-lgpl` are at
https://gist.github.com/luhenry/ceb64c52ad63c69ed0ef2aa205ddde25. The only
added dependencies are the blas, lapack, and arpack packages from
`dev.ludovic.netlib`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
