srowen commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r618425073
##########
File path: mllib-local/pom.xml
##########
@@ -75,48 +75,12 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
</dependencies>
- <profiles>
- <profile>
- <id>netlib-lgpl</id>
Review comment:
I think we need to keep this profile, even if empty, to avoid failing
builds that specify `-Pnetlib-lgpl` (think of it as deprecated).
But, something needs to pull in the `all` artifact, or else building Spark
with this profile doesn't include native libs for acceleration, right? and
those need to be behind a profile. I'd not expect this profile goes away.
Maybe you can show the relevant part of `mvn dependency:tree` or the result
of `dev/test-dependencies.sh --replace-manifest` so we can be clear about what
packages are now included at the moment. I want to make sure the default
doesn't include LGPL code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
