srowen commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r619305241
##########
File path: mllib-local/pom.xml
##########
@@ -75,48 +75,12 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
</dependencies>
- <profiles>
- <profile>
- <id>netlib-lgpl</id>
Review comment:
OK, it sounds like your solution avoids the small but important nature
of the netlib-java shim that made it problematic to include. I think it was
libgfortran - the profile didn't itself install BLAS or anything. That is, it
wasn't depending on BLAS implementations so much as something in the shim that
was linked in. I think.
I don't know this in detail enough to fully evaluate but I believe in your
assessment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
