srowen commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r620373383
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -10,6 +10,7 @@ annotations/17.0.0//annotations-17.0.0.jar
antlr-runtime/3.5.2//antlr-runtime-3.5.2.jar
antlr4-runtime/4.8-1//antlr4-runtime-4.8-1.jar
aopalliance-repackaged/2.6.1//aopalliance-repackaged-2.6.1.jar
+arpack/1.3.2//arpack-1.3.2.jar
Review comment:
There's one more minor thing to do here. Under licenses-binary/ ,
include a file like `LICENSE-blas.txt` and/or separate ones for arpack, lapack
artifacts as you wish (name doesn't matter, doesn't have to be 3 - really it's
whatever satisifies you, as long as we have a copy that's connectable to your
artifacts) with the text of the MIT license file. In `LICENSE-binary`, you'll
see a list of MIT dependencies. Just add them in there too.
I don't think any dependencies ultimately went away so there's nothing to
remove, AFAICT.
It's a formality but just ensures the license requirements are buttoned up.
##########
File path: mllib-local/pom.xml
##########
@@ -75,6 +75,11 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
Review comment:
So graphx and mllib-local would not need ARPACK, LAPACK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
