cloud-fan commented on a change in pull request #32786:
URL: https://github.com/apache/spark/pull/32786#discussion_r646588191
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/AggregatingAccumulator.scala
##########
@@ -205,6 +205,10 @@ class AggregatingAccumulator private(
buffer = other.buffer
joinedRow = other.joinedRow
}
+
+ private[execution] def addState(v: InternalRow): Unit = {
Review comment:
note: we should call `merge` not `add`, as the state to add is another
computed accumulator, not an input row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
