sarutak commented on a change in pull request #32786:
URL: https://github.com/apache/spark/pull/32786#discussion_r646668870
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/AggregatingAccumulator.scala
##########
@@ -205,6 +205,10 @@ class AggregatingAccumulator private(
buffer = other.buffer
joinedRow = other.joinedRow
}
+
+ private[execution] def addState(v: InternalRow): Unit = {
Review comment:
In fact, it's my first idea of `addState` but didn't work. I
investigated the reason and found that `merge` is not intended to be called
from Executor.
https://github.com/apache/spark/blob/33f26275f4d65f54e68f38ba0d795396a5a4d2f4/sql/core/src/main/scala/org/apache/spark/sql/execution/AggregatingAccumulator.scala#L96-L108
Do you think we can relax the rule here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
