cloud-fan commented on a change in pull request #32786:
URL: https://github.com/apache/spark/pull/32786#discussion_r646716882
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/CollectMetricsExec.scala
##########
@@ -69,7 +69,7 @@ case class CollectMetricsExec(
// - Performance issues due to excessive serialization.
Review comment:
Maybe we can try option 1 first, as it's the simplest. We just need to
update the `withSQLConf` function a little bit
```
private[this] def withSQLConf[T](body: => T): T = {
if (conf != null) {
SQLConf.withExistingConf(conf)(body)
} else {
body
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
