Ngone51 commented on a change in pull request #33340:
URL: https://github.com/apache/spark/pull/33340#discussion_r670931914
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java
##########
@@ -95,13 +95,15 @@ public void fetchBlocks(
logger.debug("External shuffle fetch from {}:{} (executor id {})", host,
port, execId);
try {
int maxRetries = conf.maxIORetries();
- RetryingBlockFetcher.BlockFetchStarter blockFetchStarter =
+ RetryingBlockTransferor.BlockTransferStarter blockFetchStarter =
(inputBlockId, inputListener) -> {
// Unless this client is closed.
if (clientFactory != null) {
+ assert inputListener instanceof BlockFetchingListener :
+ "Expecting a BlockFetchingListener, but got a
BlockPushingListener";;
Review comment:
maybe: `... but got listener $inputListener`
(it's always good to show the unexpected value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
