cloud-fan commented on a change in pull request #33822:
URL: https://github.com/apache/spark/pull/33822#discussion_r696420571
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -315,6 +315,19 @@ class JDBCSuite extends QueryTest
assert(parentPlan.isInstanceOf[org.apache.spark.sql.execution.WholeStageCodegenExec])
val node =
parentPlan.asInstanceOf[org.apache.spark.sql.execution.WholeStageCodegenExec]
assert(node.child.isInstanceOf[org.apache.spark.sql.execution.FilterExec])
+ val relation = df.queryExecution.analyzed.collectFirst {
+ case LogicalRelation(r, _, _, _) => r
+ }.get
+
assert(relation.isInstanceOf[org.apache.spark.sql.execution.datasources.jdbc.JDBCRelation])
+ val jdbcRelation =
+
relation.asInstanceOf[org.apache.spark.sql.execution.datasources.jdbc.JDBCRelation]
+ if (jdbcRelation.jdbcOptions.pushDownPredicate == false) {
Review comment:
The method name is `checkNotPushdown`, do we need this `if`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
