beliefer edited a comment on pull request #33822: URL: https://github.com/apache/spark/pull/33822#issuecomment-906031199
> Seems to me that we should push down handledFilters, not the translated filters (`pushedFilters`) @huaxingao I tried on the way, but some test case cannot pass. Please see https://github.com/apache/spark/blob/159ff9fd14f7e0581833428c495c0e2c34f7e320/sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala#L81 According to the test case, it seems that the pushed filters should as the parameters of `def buildScan`. cc @cloud-fan @gengliangwang In fact, I commit the update https://github.com/apache/spark/pull/33822/commits/0fecee8732f21e219fd00a948f92af5c8f4c7771 like your consideration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
