huaxingao commented on pull request #33822: URL: https://github.com/apache/spark/pull/33822#issuecomment-906107754
@beliefer I see. But at this line `assert(relation.unhandledFilters(FiltersPushed.list.toArray).toSet === expectedUnhandledFilters)` https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala#L331, why are we getting `unhandledFilters` from `FiltersPushed.list`? Should we get `unhandledFilters` from the original filters? I still think we shouldn't push down `unhandledFilters` to the data source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
