ByronHsu commented on a change in pull request #34411:
URL: https://github.com/apache/spark/pull/34411#discussion_r738138944
##########
File path: python/pyspark/conf.py
##########
@@ -178,9 +191,18 @@ def setAll(self, pairs):
self.set(k, v)
return self
- def get(self, key, defaultValue=None):
+ @overload
Review comment:
I add overload because If I set the return value as Optional,
https://github.com/apache/spark/blob/master/python/pyspark/sql/session.py#L613
will show error.
##########
File path: python/pyspark/conf.py
##########
@@ -178,9 +191,18 @@ def setAll(self, pairs):
self.set(k, v)
return self
- def get(self, key, defaultValue=None):
+ @overload
Review comment:
I add overload because If I set the return value as Optional,
https://github.com/apache/spark/blob/master/python/pyspark/sql/session.py#L613
will show an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
