dchvn commented on a change in pull request #34411:
URL: https://github.com/apache/spark/pull/34411#discussion_r738873431
##########
File path: python/pyspark/conf.py
##########
@@ -105,15 +108,16 @@ class SparkConf(object):
spark.home=/path
"""
- def __init__(self, loadDefaults=True, _jvm=None, _jconf=None):
+ def __init__(self, loadDefaults: bool = True, _jvm: Optional[JVMView] =
None,
+ _jconf: Optional[JavaObject] = None) -> None:
Review comment:
Some information in https://github.com/python/mypy/pull/5677 and
https://mypy.readthedocs.io/en/stable/error_code_list2.html
mypy implicitly None for type checked ```__init__``` when it take at least
one argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
