dongjoon-hyun commented on a change in pull request #34425:
URL: https://github.com/apache/spark/pull/34425#discussion_r738971254
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -218,7 +219,9 @@ class HiveExternalCatalogVersionsSuite extends
SparkSubmitTestUtils {
"--conf", s"${HiveUtils.HIVE_METASTORE_JARS.key}=maven",
"--conf", s"${WAREHOUSE_PATH.key}=${wareHousePath.getCanonicalPath}",
"--conf", s"spark.sql.test.version.index=$index",
- "--driver-java-options",
s"-Dderby.system.home=${wareHousePath.getCanonicalPath}",
+ "--driver-java-options",
s"-Dderby.system.home=${wareHousePath.getCanonicalPath} " +
+ // TODO: Consider to remove the following JVM options once the Spark
3.2 line is EOL.
Review comment:
@sarutak . We had better use IDed TODO. Could you file a JIRA and make
this `TODO(SPARK-XXX)` style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
