sarutak commented on a change in pull request #34425:
URL: https://github.com/apache/spark/pull/34425#discussion_r739012825
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -263,6 +267,8 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
versions
.filter(v => v.startsWith("3") || !TestUtils.isPythonVersionAtLeast38())
.filter(v => v.startsWith("3") ||
!SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))
+ .filter(v => !((v.startsWith("3.0") || v.startsWith("3.1")) &&
+ SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_17)))
Review comment:
> I have manually tested the new filter conditions. The version before
filter includes 2.4.8,3.0.3,3.1.2,3.2.0 and the version after filter only
includes 3.2.0
It's intended. This test works only for `3.2.0` with Java 17.
If it's not necessary to test with Java 17, I'll change this suite to just
skip to run with Java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
