LuciferYang commented on a change in pull request #34425:
URL: https://github.com/apache/spark/pull/34425#discussion_r739027309
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -218,7 +218,11 @@ class HiveExternalCatalogVersionsSuite extends
SparkSubmitTestUtils {
"--conf", s"${HiveUtils.HIVE_METASTORE_JARS.key}=maven",
"--conf", s"${WAREHOUSE_PATH.key}=${wareHousePath.getCanonicalPath}",
"--conf", s"spark.sql.test.version.index=$index",
- "--driver-java-options",
s"-Dderby.system.home=${wareHousePath.getCanonicalPath}",
+ "--driver-java-options",
s"-Dderby.system.home=${wareHousePath.getCanonicalPath} " +
Review comment:
Hmm, `JavaModuleOptions.defaultModuleOptions()` is already a String join
with one space
, like
```
-XX:+IgnoreUnrecognizedVMOptions --add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED ...
```
Why we need to call `String.join` again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
