LuciferYang commented on a change in pull request #34425:
URL: https://github.com/apache/spark/pull/34425#discussion_r739044144



##########
File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -263,6 +267,8 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
     versions
       .filter(v => v.startsWith("3") || !TestUtils.isPythonVersionAtLeast38())
       .filter(v => v.startsWith("3") || 
!SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))
+      .filter(v => !((v.startsWith("3.0") || v.startsWith("3.1")) &&
+        SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_17)))

Review comment:
       Manually test as follows:
   ```
   mvn clean install -DskipTests -pl sql/hive -am -Phive-2.3 -Phive
   mvn clean test -pl sql/hive -Phive-2.3 -Phive -Dtest=none 
-DwildcardSuites=org.apache.spark.sql.hive.HiveExternalCatalogVersionsSuite
   ```
   
   
   ```
   Run completed in 1 minute, 28 seconds.
   Total number of tests run: 1
   Suites: completed 2, aborted 0
   Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
   All tests passed.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to