cloud-fan commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r746601400
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java
##########
@@ -94,6 +104,36 @@
*/
Table loadTable(Identifier ident) throws NoSuchTableException;
+ /**
+ * Load table metadata by {@link Identifier identifier} from the catalog.
+ * <p>
+ * If the catalog supports views and contains a view for the identifier and
not a table, this
+ * must throw {@link NoSuchTableException}.
+ *
+ * @param ident a table identifier
+ * @param version version of the table
+ * @return the table's metadata
+ * @throws NoSuchTableException If the table doesn't exist or is a view
+ */
+ default Table loadTable(Identifier ident, String version) throws
NoSuchTableException {
+ throw new UnsupportedOperationException("Load table with version is not
supported.");
+ }
+
+ /**
+ * Load table metadata by {@link Identifier identifier} from the catalog.
+ * <p>
+ * If the catalog supports views and contains a view for the identifier and
not a table, this
+ * must throw {@link NoSuchTableException}.
+ *
+ * @param ident a table identifier
+ * @param timestamp timestamp of the table
Review comment:
can we define it more clearly? `microseconds since 1970-01-01 00:00:00
UTC`?
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -598,6 +598,13 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : VERSION AS OF version=INTEGER_VALUE
+ | SYSTEM_VERSION AS OF version=INTEGER_VALUE
Review comment:
I think the syntax should be FOR SYSTEM_VERSION?
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -598,6 +598,13 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : VERSION AS OF version=INTEGER_VALUE
+ | SYSTEM_VERSION AS OF version=INTEGER_VALUE
+ | TIMESTAMP AS OF timestamp=STRING
+ | SYSTEM_TIME AS OF timestamp=STRING
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
