cloud-fan commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r748057131
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsCatalogOptions.java
##########
@@ -52,4 +54,20 @@
default String extractCatalog(CaseInsensitiveStringMap options) {
return CatalogManager.SESSION_CATALOG_NAME();
}
+
+ /**
+ * Return a Timestamp String given DataFrameReader options.
+ * If this is implemented by data source, then extractTimeTravelVersion
can't be implemented.
Review comment:
It's a user error if both timestamp and version are provided in the
options. The implementation doesn't need to care about it. Spark should check
this and give a clear error message to the users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
