cloud-fan commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r748060596
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala
##########
@@ -357,3 +357,5 @@ private[sql] object SortValue {
None
}
}
+
+private[sql] final case class TimeTravelSpec(timestamp: Option[Long], version:
Option[String])
Review comment:
to make it more type-safe
```
sealed trait TimeTravelSpec
case class AsOfTimestamp(timestamp: long) extends TimeTravelSpec
case class AsOfVersion(version: Long) extends TimeTravelSpec
object TimeTravelSpec {
def create(timestamp: Option[String], version: Option[String]):
Option[TimeTravelSpec] = ...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
