cloud-fan commented on a change in pull request #34060:
URL: https://github.com/apache/spark/pull/34060#discussion_r755784540
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -156,9 +156,16 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
}
WriteToDataSourceV2Exec(writer, invalidateCacheFunc, planLater(query),
customMetrics) :: Nil
- case CreateV2Table(catalog, ident, schema, parts, props, ifNotExists) =>
+ case CreateTable(ResolvedDBObjectName(catalog, ident), schema,
partitioning, bucketSpec,
+ tableSpec, ifNotExists) =>
+ val props = CatalogV2Util.convertTableProperties(
Review comment:
I think it's better to keep the strategy rule simple and move the logic
of generating table properties into `CreateTableExec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
