HyukjinKwon commented on a change in pull request #34757:
URL: https://github.com/apache/spark/pull/34757#discussion_r759992352
##########
File path: python/pyspark/sql/session.py
##########
@@ -277,8 +277,10 @@ def getOrCreate(self) -> "SparkSession":
# Do not update `SparkConf` for existing `SparkContext`,
as it's shared
# by all sessions.
session = SparkSession(sc, options=self._options)
- for key, value in self._options.items():
-
session._jsparkSession.sessionState().conf().setConfString(key, value)
+ else:
Review comment:
Hm, in Scala side, `applyModifiableSettings` is always invoked when the
default Spark session is not found, and `SparkContext` is already running. Is
this matched with Scala side? Seems not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
