AngersZhuuuu commented on a change in pull request #34757:
URL: https://github.com/apache/spark/pull/34757#discussion_r759996260
##########
File path: python/pyspark/sql/session.py
##########
@@ -304,8 +329,13 @@ def __init__(
and not
self._jvm.SparkSession.getDefaultSession().get().sparkContext().isStopped()
):
jsparkSession =
self._jvm.SparkSession.getDefaultSession().get()
+ if options is not None:
+ self.applyModifiableSetting(jsparkSession, options)
else:
jsparkSession = self._jvm.SparkSession(self._jsc.sc(), options)
+ else:
+ if options is not None:
+ self.applyModifiableSetting(jsparkSession, options)
Review comment:
we apply options when there is a existed `SparkSession`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
