AngersZhuuuu commented on a change in pull request #34757:
URL: https://github.com/apache/spark/pull/34757#discussion_r759994141
##########
File path: python/pyspark/sql/session.py
##########
@@ -287,6 +289,29 @@ def getOrCreate(self) -> "SparkSession":
_instantiatedSession: ClassVar[Optional["SparkSession"]] = None
_activeSession: ClassVar[Optional["SparkSession"]] = None
+ def applyModifiableSetting(self, session: JavaObject, options: Dict[str,
Any]) -> None:
Review comment:
> Can we call JVM's `SparkSession.applyModifiableSetting` after making
it private[sql]?
In scala code, `applyModifiableSettings` belong to `Session.Builder`, but in
pyspark code, it handle existed session not in `Builder` but in `SparkSession`.
If we want to use, we may need to change the method `applyModifiableSettings`
to add parameter of `options`. And move this method to `SparkSession`.
I think it's ok to do this, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
