Kwafoor commented on pull request #34862:
URL: https://github.com/apache/spark/pull/34862#issuecomment-992116757


   > is it not better to explicitly cast to a larger integer type?
   
   Explicitly cast string to a larger integer type is right, but user may 
implicit cast and he didn't find any exception( it is possible for a big query, 
and I have encountered).
   If he doesn't check the results, a hug trouble will make.And even if he 
checked, it's so hard to find a such sql error(User may ignore it, for example 
hive for this cast type is right.)
   So, I just want to remind user when ansi is not enabled and overflow 
happened, suggest them where your sql is not right.
   Return null rather than Exception is too implicit, user always ignore it(If 
a big query with many filter, it is even more.).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to