Kwafoor commented on pull request #34862: URL: https://github.com/apache/spark/pull/34862#issuecomment-992185361
> > But I still think SparkSQL should remind user where you wrong. > > This doesn't answer the question of why you only fix string integer comparison here. I think string integer comparison is common and easier to encounter,I haven't meet the other case.I have just tried, and also encounter problem(long, short, etc). And I agree with you it's better to not introduce inconsistency to the system. About other like math(+-*/), it's right about string and integer(SparkSQL cast string to double type). May be I make a confusion title.I found the issue in comparing String and IntegerType, and the reason is string2int cast overflow. So I fix issue by thrown exception in cast code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
