Kwafoor commented on pull request #34862: URL: https://github.com/apache/spark/pull/34862#issuecomment-992127549
> > when overflow happened SparkSQL return wrong results(null), but user didn't get any remind, I think it is a problem. > > The problem has been there for many years, and many operations/functions are affected (math operations, cast, etc.). I don't think it's justified to change string and integer comparison only (and introduce inconsistency to the system). ANSI mode is the way to go. If ANSI mode is too strict, we can relax it a bit to make it fit the real-world use cases better. I agree with ansi, but in current place user didn't get any remind is a problem. I haven't think this could introduce inconsistency to the system yet. User didn't get any exception but get a null result, it can truly cause confusion, user may ignore the sql error rather than check and find some problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
