dongjoon-hyun commented on a change in pull request #34983:
URL: https://github.com/apache/spark/pull/34983#discussion_r776464668
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientUtils.scala
##########
@@ -87,11 +87,15 @@ private[spark] object KubernetesClientUtils extends Logging
{
* Build a Config Map that will hold the content for environment variable
SPARK_CONF_DIR
* on remote pods.
*/
- def buildConfigMap(configMapName: String, confFileMap: Map[String, String],
- withLabels: Map[String, String] = Map()): ConfigMap = {
+ def buildConfigMap(
+ configMapName: String,
+ confFileMap: Map[String, String],
+ configMapNameSpace: String,
Review comment:
Please try to get namespace via `confFileMap` instead changing this
method signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
