dongjoon-hyun commented on a change in pull request #34983:
URL: https://github.com/apache/spark/pull/34983#discussion_r776895313
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientUtilsSuite.scala
##########
@@ -82,8 +81,9 @@ class KubernetesClientUtilsSuite extends SparkFunSuite with
BeforeAndAfter {
}
test("verify that configmap built as expected") {
- val configMapName = "testConfigMapName"
- val properties = Map(Config.KUBERNETES_NAMESPACE.key -> "default")
+ val configMapName = java.util.UUID.randomUUID.toString
Review comment:
@dcoliversun . Apache Spark recommends not to hide your import in the
code. Especially, you are using twice at line 84 and 85. Your code is verbose
due to the repeatability and not good at the readability too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
