dongjoon-hyun commented on a change in pull request #34983:
URL: https://github.com/apache/spark/pull/34983#discussion_r776576171
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientUtilsSuite.scala
##########
@@ -76,4 +80,26 @@ class KubernetesClientUtilsSuite extends SparkFunSuite with
BeforeAndAfter {
"testConf.3" -> "test123456")
assert(output === expectedOutput)
}
+
+ test("verify that configmap built as expected") {
+ val configMapName = "testConfigMapName"
+ val properties = Map(Config.KUBERNETES_NAMESPACE.key -> "default")
Review comment:
If you don't mind, could you use a random name here? Although the
previous code doesn't attache the namespace, this `default` is too generic to
be in the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
