ssimeonov commented on a change in pull request #35084:
URL: https://github.com/apache/spark/pull/35084#discussion_r777332336
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -803,15 +803,9 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product with Tre
case tn: TreeNode[_] => tn.simpleString(maxFields) :: Nil
case seq: Seq[Any] if
seq.toSet.subsetOf(allChildren.asInstanceOf[Set[Any]]) => Nil
case iter: Iterable[_] if iter.isEmpty => Nil
- case seq: Seq[_] =>
Review comment:
@HyukjinKwon I added the bigger (DRYing) change below so you can see it
live. It's mechanical (low risk), but I'll be happy to revert back to the
single parens change if you are troubled by it.
It's just messy code: not even cut'n'paste as the two implementations for
`Set[_]` differ syntactically while doing exactly the same thing (one creates
local `val` to simplify the expression).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
