stczwd commented on a change in pull request #35185:
URL: https://github.com/apache/spark/pull/35185#discussion_r785993842



##########
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##########
@@ -286,6 +289,7 @@ private[spark] class TaskDataWrapper(
       taskId,
       index,
       attempt,
+      partitionId,
       new Date(launchTime),

Review comment:
       I have test it with event files, leveldb and rocksdb, and it is ok with 
rocksdb and event files, which retruns `"partitionId" : -1,`. But when testing 
leveldb, we get `"partitionId" : 0,`, which is different from what we expected.
   
   BTW, the test scenario is generating eventLog and leveldb/rocksdb with old 
spark-client and reading it on new spark-client which has this pr.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to