mridulm commented on a change in pull request #35185:
URL: https://github.com/apache/spark/pull/35185#discussion_r786339392
##########
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##########
@@ -286,6 +289,7 @@ private[spark] class TaskDataWrapper(
taskId,
index,
attempt,
+ partitionId,
new Date(launchTime),
Review comment:
Would be good to see if we can default the value to -1 if missing.
Else cleaning up all level-db would be a prerequisite to leveraging this.
I am not sure what is the cleanest way to enforce incompatible leveldb
format changes - IIRC you had made some changes recently which require regen,
right @dongjoon-hyun ? Any suggestions ? (IIRC we did not bump up the store
version)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
