Ngone51 commented on a change in pull request #35185:
URL: https://github.com/apache/spark/pull/35185#discussion_r787439464
##########
File path: project/MimaExcludes.scala
##########
@@ -48,7 +48,10 @@ object MimaExcludes {
// [SPARK-37780][SQL] QueryExecutionListener support SQLConf as
constructor parameter
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.util.ExecutionListenerManager.this"),
// [SPARK-37786][SQL] StreamingQueryListener support use SQLConf.get to
get corresponding SessionState's SQLConf
-
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.streaming.StreamingQueryManager.this")
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.streaming.StreamingQueryManager.this"),
+
+ // [SPARK-37831][CORE] TaskInfo add partitionId as a constructor parameter
Review comment:
nit: be consistent with the title?
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala
##########
@@ -35,12 +35,34 @@ class TaskInfo(
*/
val index: Int,
val attemptNumber: Int,
+ /**
+ * The actual RDD partition ID in this task.
+ * The ID of the RDD partition is always same across task or stage retries.
+ * This will be -1 for historical data, and available for all spark
applications since 3.3.
Review comment:
nit: `...for all applications since Spark 3.3.`
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala
##########
@@ -35,12 +35,34 @@ class TaskInfo(
*/
val index: Int,
val attemptNumber: Int,
+ /**
+ * The actual RDD partition ID in this task.
+ * The ID of the RDD partition is always same across task or stage retries.
Review comment:
nit: `...across task attempts...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
