bjornjorgensen commented on a change in pull request #35296:
URL: https://github.com/apache/spark/pull/35296#discussion_r790691873



##########
File path: python/pyspark/pandas/generic.py
##########
@@ -904,6 +904,8 @@ def to_json(
 
         .. note:: output JSON format is different from pandas'. It always use 
`orient='records'`
             for its output. This behaviour might have to change in the near 
future.
+        
+        .. note:: If column have only NaN or Null values. The column well be 
deleted.

Review comment:
       Yes, this well be the best option. But are you thinking about changing 
this in https://github.com/apache/spark/pull/26098
   
   // Whether to ignore column of all null during json generating
     val structIngoreNull = parameters.getOrElse("structIngoreNull", 
"true").toBoolean
   
   or just change the “koalas” code? 
   
   Yes, pandas writes both in JSON. I have updated the jira post with it. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to