zero323 commented on a change in pull request #35296:
URL: https://github.com/apache/spark/pull/35296#discussion_r790766474
##########
File path: python/pyspark/pandas/generic.py
##########
@@ -904,6 +904,8 @@ def to_json(
.. note:: output JSON format is different from pandas'. It always use
`orient='records'`
for its output. This behaviour might have to change in the near
future.
+
+ .. note:: If column have only NaN or Null values. The column well be
deleted.
Review comment:
> or just change the “koalas” code?
I concur with @HyukjinKwon ‒ only `pyspark.pandas` code should be changed,
and that for the sake of the API consistence.
As of the main writer behavior, I am strongly against changing defaults at
all (not only in this PR). In general, omitting NULL fields in the output is
the preferred behavior and there is no good justification for flipping the
defaults now, after API being stable for years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
