HyukjinKwon commented on a change in pull request #35296:
URL: https://github.com/apache/spark/pull/35296#discussion_r791258906
##########
File path: python/pyspark/pandas/generic.py
##########
@@ -889,6 +889,7 @@ def to_json(
lines: bool = True,
partition_cols: Optional[Union[str, List[str]]] = None,
index_col: Optional[Union[str, List[str]]] = None,
+ ignoreNullFields: bool = False,
Review comment:
maybe let's just don't add it as a parameter for now ..... I prefer
second way in https://github.com/apache/spark/pull/35296#discussion_r790685881
because technically `ignoreNullFields` is PySpark options to bypass, and makes
less sense to document in pandas api doc surface .. we can just say that these
`options` are for PySpark I/O options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
