c21 commented on a change in pull request #35273:
URL: https://github.com/apache/spark/pull/35273#discussion_r791326607
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala
##########
@@ -44,8 +42,7 @@ case class SortAggregateExec(
with AliasAwareOutputOrdering {
override lazy val metrics = Map(
- "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"),
- "aggTime" -> SQLMetrics.createTimingMetric(sparkContext, "time in
aggregation build"))
Review comment:
@cloud-fan - for hash agg and object hash agg, yes, the `aggTime` is the
time to build the hash table. For sort aggregate, there's no proper definition
of agg time, as the whole time during sort aggregate is doing aggregate.
There's not that useful to measure the execution time for sort aggregate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
