c21 commented on a change in pull request #35273:
URL: https://github.com/apache/spark/pull/35273#discussion_r791345045
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregateCodegenSupport.scala
##########
@@ -47,6 +47,12 @@ trait AggregateCodegenSupport
*/
private var bufVars: Seq[Seq[ExprCode]] = _
+ /**
+ * Whether this operator has an aggregate build phase.
+ * Only [[HashAggregateExec]] has build phase now.
+ */
+ protected def hasAggBuild: Boolean
Review comment:
do we want to report `aggTime` as 0 now for `HashAggregate` without
group by columns?
I am fine with changing to report 0 now, as the SQL metrics shown up as
`time in aggregation build` in Spark UI for end users. There's no build for
`HashAggregate` without group by columns, so I think it's a valid fix. Just
want to mention here as this is a user-facing change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
