cloud-fan commented on a change in pull request #35273:
URL: https://github.com/apache/spark/pull/35273#discussion_r791346306
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregateCodegenSupport.scala
##########
@@ -47,6 +47,12 @@ trait AggregateCodegenSupport
*/
private var bufVars: Seq[Seq[ExprCode]] = _
+ /**
+ * Whether this operator has an aggregate build phase.
+ * Only [[HashAggregateExec]] has build phase now.
+ */
+ protected def hasAggBuild: Boolean
Review comment:
ok maybe we can do the change in a new PR. Let's just use a proper name
in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
