mridulm commented on a change in pull request #35085:
URL: https://github.com/apache/spark/pull/35085#discussion_r795082810
##########
File path:
core/src/main/java/org/apache/spark/shuffle/sort/io/LocalDiskShuffleMapOutputWriter.java
##########
@@ -87,7 +86,7 @@ public ShufflePartitionWriter getPartitionWriter(int
reducePartitionId) throws I
}
lastPartitionId = reducePartitionId;
if (outputTempFile == null) {
- outputTempFile = Utils.tempFileWith(outputFile);
+ outputTempFile = blockResolver.createTempFile(outputFile);
Review comment:
That makes sense - given this, why not simply use
`DiskBlockManager.createDirWithPermission770` while creating the directory and
avoid needing to set any permission ? (we will need to now handle linux vs
windows/etc now in `createDirWithPermission770` though)
The directory creation, via mkdir, will override the umask but preserve the
setgid. Given this, file creation will not need acl changes/be readable by
shuffle service, and dir will be group readable/listable for shuffe server also.
Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
