mridulm commented on a change in pull request #35085:
URL: https://github.com/apache/spark/pull/35085#discussion_r795085100
##########
File path: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala
##########
@@ -94,7 +95,13 @@ private[spark] class DiskBlockManager(
} else {
val newDir = new File(localDirs(dirId), "%02x".format(subDirId))
if (!newDir.exists()) {
- Files.createDirectory(newDir.toPath)
+ // SPARK-37618: Create dir as group writable so files within can be
deleted by the
+ // shuffle service
+ val path = newDir.toPath
+ Files.createDirectory(path)
+ val currentPerms = Files.getPosixFilePermissions(path)
+ currentPerms.add(PosixFilePermission.GROUP_WRITE)
Review comment:
This is what I tried:
{code}
mkdir t1 ; chgrp mridul t1; chmod g+s t1; mkdir -m770 t1/t2; mkdir -m770
t1/t2/t3; cp ~/.bashrc t1/t2/t3/bashrc; ls -al t1/t2/
total 12
drwxrws--- 3 test mridul 4096 Jan 29 13:17 .
drwxrwsr-x 3 test mridul 4096 Jan 29 13:17 ..
drwxrws--- 2 test mridul 4096 Jan 29 13:17 t3
{code}
Looks like mkdir honors it.
The issue is that java is overwriting the permission with the new values
from setPosixPermissions - and that is blind to the earlier gid bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
