cloud-fan commented on a change in pull request #35355:
URL: https://github.com/apache/spark/pull/35355#discussion_r802717989
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -229,6 +229,51 @@ abstract class JdbcDialect extends Serializable with
Logging{
}
}
+ /**
+ * Create schema with an optional comment. Empty string means no comment.
+ */
+ def createSchema(
+ conn: Connection, options: JDBCOptions, schema: String, comment:
String): Unit = {
+ val statement = conn.createStatement
Review comment:
shall we pass `statement` as parameter to `createSchema `? Then Spark
can set the timeout and close the statement at the end, leave less job to the
JDBC dialect implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
